Conversation
BoDonkey
approved these changes
Nov 12, 2025
| if (Date.now() - start >= (self.options.longPollingTimeout || 10000)) { | ||
| if ( | ||
| self.options.longPolling && | ||
| (Date.now() - start >= self.options.longPollingTimeout) |
Member
Author
There was a problem hiding this comment.
Correct, no fallback needed, because this is code that preempts making a database query at all if the long polling timer runs out, which isn't relevant in vanilla polling.
haroun
added a commit
that referenced
this pull request
Nov 19, 2025
* main: PRO-8708: bring back passing of the actual area options in the form developers expect to see them to custom insert menu item components (#5162) adds object of useful error when widget fails to render (#5141) add addMissingSchemaFields task (#5101) Pro 8360 box field (#5142) Pro 8671 fix localize modal (#5156) longPolling: false option (#5154) PRO-5472: file widget (#5126)
haroun
added a commit
that referenced
this pull request
Nov 19, 2025
* main: PRO-8708: bring back passing of the actual area options in the form developers expect to see them to custom insert menu item components (#5162) adds object of useful error when widget fails to render (#5141) add addMissingSchemaFields task (#5101) Pro 8360 box field (#5142) Pro 8671 fix localize modal (#5156) longPolling: false option (#5154) PRO-5472: file widget (#5126)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good testing is in place: we're using this already at the moment, via a branch dependency, in our public demo.
For user experience, long polling is good. For lighthouse scores when logged in, it is not so good, and some customers may find themselves under similar pressure. Now they have choices.